Skip to content

Conversation

jalolk
Copy link

@jalolk jalolk commented Sep 24, 2025

Ticket

JIRA-VPN-XXXX

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Checklist:

  • Changelog

Screenshots (optional, if UI related)


This change is Reviewable

@jalolk jalolk requested a review from tommyv1987 September 24, 2025 15:46
@jalolk jalolk self-assigned this Sep 24, 2025
@github-actions github-actions bot requested review from doums September 24, 2025 15:47
@jalolk jalolk marked this pull request as draft September 24, 2025 15:48
"dev:app": "tauri dev",
"dev:browser": "vite --mode dev-browser",
"check": "run-s lint tscheck fmt",
"check": "run-s lint tscheck fmt test",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove test from the check script
we do not want it here as running unit tests is a heavy task
and that check command is to perform quick checks during dev iterations

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test script will be added to github workflow CI

Copy link
Contributor

@doums doums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my comments

@doums
Copy link
Contributor

doums commented Sep 25, 2025

Please try to set up Typescript to use different and dedicated setup/config for tests. Do not modify the main config used by app code.
Also, tscheck or default tsc should exclude all test code. That's not relevant. Preserve the existing behavior and do not add code to be parsed (jest/tests code) by the main existing config because this will slow down dev iterations.

@doums
Copy link
Contributor

doums commented Sep 25, 2025

To say the least, I'm quite skeptical on the real benefits to add such tests. This will add its batch of maintenance work and introduces the infamous “unit tests are broken” flow. Which will end as frictions and inevitably will slow down the development process.

For which concrete benefits? I don't remember we encountered a considerable amount of cases of dysfunctional UI component so far.
(I'm not pretending this will never happen)

But right now, the UI layer as proved to be stable and reliable. So I don't get the reasons/motivations here to add this whole layer of UI unit tests (including its batch of tradeoffs)?

@jalolk jalolk force-pushed the tests/add-unit-tests-for-react-components branch 4 times, most recently from 615ba5c to 1518a90 Compare October 1, 2025 13:10
@jalolk jalolk force-pushed the tests/add-unit-tests-for-react-components branch from 6075431 to 07f8e78 Compare October 2, 2025 12:09
@jalolk jalolk marked this pull request as ready for review October 3, 2025 09:31
@github-actions github-actions bot requested a review from doums October 3, 2025 09:32
@github-actions github-actions bot requested a review from doums October 6, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants