-
Notifications
You must be signed in to change notification settings - Fork 30
tests: add unit tests for react components #3514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
nym-vpn-app/package.json
Outdated
"dev:app": "tauri dev", | ||
"dev:browser": "vite --mode dev-browser", | ||
"check": "run-s lint tscheck fmt", | ||
"check": "run-s lint tscheck fmt test", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, remove test from the check script
we do not want it here as running unit tests is a heavy task
and that check command is to perform quick checks during dev iterations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test
script will be added to github workflow CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my comments
Please try to set up Typescript to use different and dedicated setup/config for tests. Do not modify the main config used by app code. |
To say the least, I'm quite skeptical on the real benefits to add such tests. This will add its batch of maintenance work and introduces the infamous “unit tests are broken” flow. Which will end as frictions and inevitably will slow down the development process. For which concrete benefits? I don't remember we encountered a considerable amount of cases of dysfunctional UI component so far. But right now, the UI layer as proved to be stable and reliable. So I don't get the reasons/motivations here to add this whole layer of UI unit tests (including its batch of tradeoffs)? |
615ba5c
to
1518a90
Compare
6075431
to
07f8e78
Compare
Ticket
JIRA-VPN-XXXX
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Checklist:
Screenshots (optional, if UI related)
This change is