-
Notifications
You must be signed in to change notification settings - Fork 30
Handle register account #3701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Handle register account #3701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @dainius-nym and @mrkiwi)
nym-vpn-core/crates/nym-vpn-account-controller/src/state_machine/syncing_state/mod.rs
line 240 at r1 (raw file):
let res = handler::handle_register_account(shared_state, account, platform).await; return_sender.send(res); } AccountCommand::ForgetAccount(return_sender) => {
Formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @dainius-nym, @mrkiwi, and @neacsu)
nym-vpn-core/crates/nym-vpn-account-controller/src/state_machine/syncing_state/requesting_zknym_state.rs
line 230 at r1 (raw file):
let res = handler::handle_register_account(shared_state, account, platform).await; return_sender.send(res); } AccountCommand::ForgetAccount(return_sender) => {
Formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 7 files reviewed, 2 unresolved discussions (waiting on @dainius-nym, @mrkiwi, and @pronebird)
nym-vpn-core/crates/nym-vpn-account-controller/src/state_machine/syncing_state/mod.rs
line 240 at r1 (raw file):
Previously, pronebird (Andrej Mihajlov) wrote…
Formatting
Done.
nym-vpn-core/crates/nym-vpn-account-controller/src/state_machine/syncing_state/requesting_zknym_state.rs
line 230 at r1 (raw file):
Previously, pronebird (Andrej Mihajlov) wrote…
Formatting
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pronebird reviewed 3 of 5 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dainius-nym and @mrkiwi)
Ticket
JIRA-VPN-4245
Description
Re-implement the handling of registration account for IAP (non-iOS, which uses the raw variant)
Checklist:
Screenshots (optional, if UI related)
This change is