Skip to content

Conversation

neacsu
Copy link
Collaborator

@neacsu neacsu commented Oct 17, 2025

Ticket

JIRA-VPN-4245

Description

Re-implement the handling of registration account for IAP (non-iOS, which uses the raw variant)

Checklist:

  • Changelog

Screenshots (optional, if UI related)


This change is Reviewable

@pronebird pronebird requested a review from mrkiwi October 17, 2025 13:12
Copy link
Collaborator

@pronebird pronebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @dainius-nym and @mrkiwi)


nym-vpn-core/crates/nym-vpn-account-controller/src/state_machine/syncing_state/mod.rs line 240 at r1 (raw file):

                        let res = handler::handle_register_account(shared_state, account, platform).await;
                        return_sender.send(res);
                    }                    AccountCommand::ForgetAccount(return_sender) => {

Formatting

Copy link
Collaborator

@pronebird pronebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @dainius-nym, @mrkiwi, and @neacsu)


nym-vpn-core/crates/nym-vpn-account-controller/src/state_machine/syncing_state/requesting_zknym_state.rs line 230 at r1 (raw file):

                        let res = handler::handle_register_account(shared_state, account, platform).await;
                        return_sender.send(res);
                    }                    AccountCommand::ForgetAccount(return_sender) => {

Formatting

Copy link
Collaborator Author

@neacsu neacsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, 2 unresolved discussions (waiting on @dainius-nym, @mrkiwi, and @pronebird)


nym-vpn-core/crates/nym-vpn-account-controller/src/state_machine/syncing_state/mod.rs line 240 at r1 (raw file):

Previously, pronebird (Andrej Mihajlov) wrote…

Formatting

Done.


nym-vpn-core/crates/nym-vpn-account-controller/src/state_machine/syncing_state/requesting_zknym_state.rs line 230 at r1 (raw file):

Previously, pronebird (Andrej Mihajlov) wrote…

Formatting

Done.

@neacsu neacsu requested a review from pronebird October 17, 2025 15:43
Copy link
Collaborator

@pronebird pronebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pronebird reviewed 3 of 5 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dainius-nym and @mrkiwi)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants