Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: custom error type ErrTokenExpiredError #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature: custom error type ErrTokenExpiredError #33

wants to merge 2 commits into from
+3 −1

Conversation

hazcod
Copy link

@hazcod hazcod commented Aug 31, 2021 •
edited
Loading

This changes the token_validator to return a ErrTokenExpiredError instead of ErrTokenValidationError.
This allows us to check for token expiration which differs from a regular token error. (e.g. trigger a refresh).

@hazcod
Copy link
Author

hazcod commented Sep 14, 2021

FYI @o1egl

o1egl
o1egl reviewed Sep 14, 2021
View reviewed changes
Copy link
Owner

@o1egl o1egl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add test cases for it

Gnarnar
Gnarnar approved these changes Oct 18, 2021
View reviewed changes
Copy link

@Gnarnar Gnarnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@o1egl o1egl o1egl left review comments

@Gnarnar Gnarnar Gnarnar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hazcod @o1egl @Gnarnar