Skip to content

correct typo? #2658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

correct typo? #2658

wants to merge 1 commit into from
+1 −1

Conversation

ShalokShalom
Copy link

I assume this was meant?

Change summary

Submission Checklist:

  • Descriptive active voice - Do descriptive sentences have a clear subject and action verb?
  • Answer the question at hand - Does the documentation answer a what, why, how, or where type of question?
  • Consistency - Does the content consistently follow the Style Guide?
  • Help the user - Does the documentation show the user something meaningful?

@ShalokShalom
correct typo?
5e70b11 
I assume this was meant?

Signed-off-by: ShalokShalom <[email protected]>
@ShalokShalom ShalokShalom requested a review from a team as a code owner April 30, 2025 13:03
@ShaunaGordon ShaunaGordon added the do-not-merge/wrong-base-branch Indicates a PR that wants to be merged into the wrong originating branch label May 1, 2025
ShaunaGordon
ShaunaGordon requested changes May 1, 2025
View reviewed changes
Copy link
Contributor

@ShaunaGordon ShaunaGordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good, but the base branch is incorrect. PRs go to the development branch, just like on the main O3DE repo.

@ShalokShalom
Copy link
Author

The change itself looks good, but the base branch is incorrect. PRs go to the development branch, just like on the main O3DE repo.

Well, that is what happens, when you press "Edit in Github" on the top right:
https://www.docs.o3de.org/docs/atom-guide/look-dev/tools/material-editor/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaunaGordon ShaunaGordon ShaunaGordon requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
do-not-merge/wrong-base-branch Indicates a PR that wants to be merged into the wrong originating branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShalokShalom @ShaunaGordon