Skip to content

Cherry picks 25050 #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ShaunaGordon
Copy link
Contributor

@ShaunaGordon ShaunaGordon commented May 29, 2025

guillaume-haerinck and others added 3 commits May 29, 2025 13:16
* start CPU profiling doc

Signed-off-by: guillaume-haerinck <[email protected]>

* More progress in cpu profiler doc

Signed-off-by: guillaume-haerinck <[email protected]>

* tracy build steps on linux

Signed-off-by: guillaume-haerinck <[email protected]>

* side documentation for gem setup

Signed-off-by: guillaume-haerinck <[email protected]>

* cpu profiler doc almost done

Signed-off-by: guillaume-haerinck <[email protected]>

* documentation done

Signed-off-by: guillaume-haerinck <[email protected]>

* Add missing index description

Signed-off-by: guillaume-haerinck <[email protected]>

* Update content/docs/user-guide/gems/reference/debug/imgui.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/gems/reference/debug/imgui.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/gems/reference/debug/imgui.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/profiling/cpu_profiling/_index.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Pr feedbacks

Signed-off-by: guillaume-haerinck <[email protected]>

* Pr feedbacks 2

Signed-off-by: guillaume-haerinck <[email protected]>

* use right annotation for ui elements

Signed-off-by: guillaume-haerinck <[email protected]>

* further button format fixes

Signed-off-by: guillaume-haerinck <[email protected]>

* last batch of fixes

Signed-off-by: guillaume-haerinck <[email protected]>

* Update content/docs/user-guide/project-config/register-gems.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/project-config/register-gems.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

* Update content/docs/user-guide/project-config/register-gems.md

Co-authored-by: Shauna Gordon <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>

---------

Signed-off-by: guillaume-haerinck <[email protected]>
Signed-off-by: Guillaume Haerinck <[email protected]>
Co-authored-by: Shauna Gordon <[email protected]>
GPU bubbles mean macroscopical idle time spans in a GPU timeline, most likely due to inefficient uses of graphics APIs on the CPU side, if you fill up such bubbles you are doing synchronized compute. While Async Compute executes simultaneously/concurrently when there is a graphics task, i.e., not a bubble, what Async Compute really fill up is SIMD slots that are not occupied by graphics wavefronts due to some bottleneck preventing a higher occupancy, so that compute wavefronts may execute when graphics wavefronts are blocked.

Signed-off-by: ohmaya <[email protected]>
Do not describe Windows as a primary platform, closes o3de#2669

Signed-off-by: André L. Alvares <[email protected]>
@ShaunaGordon ShaunaGordon requested a review from a team as a code owner May 29, 2025 17:18
Copy link

@JT-SCB-GameDesign JT-SCB-GameDesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jhanca-robotecai
Copy link
Contributor

Should we cherry-pick #2673 as well? I would say yes.

@JT-SCB-GameDesign
Copy link

JT-SCB-GameDesign commented Jun 9, 2025

Yes @ 2673, we are working with Nick on getting it into the right branch. It came via the button on the docs site but to the wrong branch.
UPDATE: looks like it's already been taken care of as far as merged into development.
Looks like it just needs to be listed here to be cherry picked into stab/25050 to my still getting educated eyes.

@jhanca-robotecai
Copy link
Contributor

jhanca-robotecai commented Jun 10, 2025

UPDATE: looks like it's already been taken care of as far as merged into development.

Yes, I took care of that.

Looks like it just needs to be listed here to be cherry picked into stab/25050 to my still getting educated eyes.

This PR comes from Shauna's fork. We do not have permissions to add any commits to the branches on this repo. Hence it has to be done by Shauna or via a separate PR.

* Add Hugo Odie as a module.
* Also make some notes about the replacements line and add one for the theme
* Remove theme files.
* Recommend replacements line.

Signed-off-by: Shauna Gordon <[email protected]>
@ShaunaGordon ShaunaGordon requested review from a team as code owners June 10, 2025 20:36
Fixes some hiccups encountered when I followed this guide.

Signed-off-by: Nicholas Lawson <[email protected]>
@ShaunaGordon
Copy link
Contributor Author

Added #2673 and #2681

@ShaunaGordon ShaunaGordon merged commit d45702a into o3de:stabilization/25050 Jun 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants