Skip to content

Changing gpu bubbles #2675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Conversation

ohmaya
Copy link
Contributor

@ohmaya ohmaya commented May 29, 2025

As commented in the previous pull:
"within a frame" is for "GPU bubbles", I'd like to further remove "within a frame".

Change summary

Submission Checklist:

  • Descriptive active voice - Do descriptive sentences have a clear subject and action verb?
  • Answer the question at hand - Does the documentation answer a what, why, how, or where type of question?
  • Consistency - Does the content consistently follow the Style Guide?
  • Help the user - Does the documentation show the user something meaningful?

ohmaya added 2 commits May 25, 2025 12:14
GPU bubbles mean macroscopical idle time spans in a GPU timeline, most likely due to inefficient uses of graphics APIs on the CPU side, if you fill up such bubbles you are doing synchronized compute. While Async Compute executes simultaneously/concurrently when there is a graphics task, i.e., not a bubble, what Async Compute really fill up is SIMD slots that are not occupied by graphics wavefronts due to some bottleneck preventing a higher occupancy, so that compute wavefronts may execute when graphics wavefronts are blocked.

Signed-off-by: ohmaya <[email protected]>
@ohmaya ohmaya requested a review from a team as a code owner May 29, 2025 21:48
@ShaunaGordon
Copy link
Contributor

Hey @ohmaya, it looks like another PR has edited this line since this PR was opened. Can you please take a look at it and see whether this PR still applies, and decide how to proceed with regard to the conflicting changes? Thanks!

@ohmaya
Copy link
Contributor Author

ohmaya commented Jun 7, 2025

@ShaunaGordon

I mentioned 'remove "within a frame"' in the previous pull's comment, however, it looks no reviewer modified my previous pull for this suggested removal, so I had to initiate another pull request.

And, what is the conflict now? If no reviewer modified my previous pull, my 2 commits in my branch should merge perfectly to development branch, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants