Release 1.6.2 #61
sandrobonazzolaAnnotations
10 errors and 10 warnings
|
var-naming[no-role-prefix]:
roles/ovirt_collectd/defaults/main.yml#L3
Variables names from within roles should use ovirt_collectd_ as a prefix. (vars: collectd_service_name)
|
|
fqcn[action-core]:
roles/ovirt_collectd/handlers/main.yml#L2
Use FQCN for builtin module actions (service).
|
|
name[casing]:
roles/ovirt_collectd/handlers/main.yml#L2
All names should start with an uppercase letter.
|
|
schema[meta]:
roles/ovirt_collectd/meta/main.yml#L1
$.dependencies[0] 'ovirt_ovirt_include_vars_files' is not of type 'object'. See https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_reuse_roles.html#using-role-dependencies
|
|
var-naming[no-role-prefix]:
roles/ovirt_dashboards_examples/defaults/main.yml#L2
Variables names from within roles should use ovirt_dashboards_examples_ as a prefix. (vars: logging_output_type)
|
|
var-naming[no-role-prefix]:
roles/ovirt_dashboards_examples/defaults/main.yml#L4
Variables names from within roles should use ovirt_dashboards_examples_ as a prefix. (vars: ovirt_metrics_pkg_sysconf_dir)
|
|
var-naming[no-role-prefix]:
roles/ovirt_dashboards_examples/defaults/main.yml#L7
Variables names from within roles should use ovirt_dashboards_examples_ as a prefix. (vars: ovirt_metrics_dashboards_examples_dir)
|
|
schema[meta]:
roles/ovirt_dashboards_examples/meta/main.yml#L1
$.dependencies[0] 'ovirt_ovirt_include_vars_files' is not of type 'object'. See https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_reuse_roles.html#using-role-dependencies
|
|
key-order[task]:
roles/ovirt_dashboards_examples/tasks/main.yml#L3
You can improve the task key order to: when, block
|
|
name[missing]:
roles/ovirt_dashboards_examples/tasks/main.yml#L3
All tasks should be named.
|
|
jinja[spacing]:
roles/ovirt_logging/tasks/main.yml#L76
Jinja2 spacing could be improved: {{ collect_ovirt_collectd_metrics|d(true) }} -> {{ collect_ovirt_collectd_metrics | d(true) }}
|
|
jinja[spacing]:
roles/ovirt_logging/tasks/main.yml#L76
Jinja2 spacing could be improved: {{ hostvars\[inventory_hostname]["ovirt_vds_cluster_name"]|d(host_deploy_cluster_name)|d(engine_cluster) }} -> {{ hostvars\[inventory_hostname]["ovirt_vds_cluster_name"] | d(host_deploy_cluster_name) | d(engine_cluster) }}
|
|
jinja[spacing]:
roles/ovirt_logging/tasks/main.yml#L76
Jinja2 spacing could be improved: {{ logging_purge_confs|d(true) }} -> {{ logging_purge_confs | d(true) }}
|
|
jinja[spacing]:
roles/ovirt_logging/tasks/main.yml#L76
Jinja2 spacing could be improved: {{ rsyslog_max_message_size|d("64k") }} -> {{ rsyslog_max_message_size | d("64k") }}
|
|
jinja[spacing]:
roles/ovirt_logging/tasks/main.yml#L91
Jinja2 spacing could be improved: {{ logging_flows|d([]) + \[basic_flow] }} -> {{ logging_flows | d([]) + \[basic_flow] }}
|
|
jinja[spacing]:
roles/ovirt_logging/tasks/main.yml#L91
Jinja2 spacing could be improved: {{ logging_inputs|d([]) + \[basic_input] }} -> {{ logging_inputs | d([]) + \[basic_input] }}
|
|
jinja[spacing]:
roles/ovirt_logging/tasks/main.yml#L91
Jinja2 spacing could be improved: {{ logging_outputs|d([]) + \[default_files_output] }} -> {{ logging_outputs | d([]) + \[default_files_output] }}
|
|
jinja[spacing]:
roles/ovirt_logging/tasks/main.yml#L109
Jinja2 spacing could be improved: {{ logging_flows|d([]) + \[vdsm_flow] }} -> {{ logging_flows | d([]) + \[vdsm_flow] }}
|
|
jinja[spacing]:
roles/ovirt_logging/tasks/main.yml#L109
Jinja2 spacing could be improved: {{ logging_inputs|d([]) + \[vdsm_input] }} -> {{ logging_inputs | d([]) + \[vdsm_input] }}
|
|
jinja[spacing]:
roles/ovirt_logging/tasks/main.yml#L124
Jinja2 spacing could be improved: {{ logging_flows|d([]) + \[engine_flow] }} -> {{ logging_flows | d([]) + \[engine_flow] }}
|