Update -> upsert #2082
Draft
Update -> upsert #2082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfhandl
reviewed
May 15, 2025
| @@ -124,7 +124,7 @@ be processed in an all-or-nothing fashion. | |||
| #### ##subsubsubsec Returning Results from Data Modification Requests | |||
|
|
|||
| Clients can request whether created or modified resources are returned | |||
| from [create](#CreateanEntity), [update](#UpdateanEntity), and | |||
| from [create](#CreateanEntity), [upsert](#UpsertanEntity), and | |||
| [upsert](#UpsertanEntity) operations using the | |||
There was a problem hiding this comment.
Now upsert appears twice
| value obtained from a previous request. If an ETag is provided that does not match the ETag | ||
| value of the entity being updated, or if an ETag is provided for an entity that does not | ||
| value of the entity being d, or if an ETag is provided for an entity that does not |
There was a problem hiding this comment.
"updated" instead of "d"?
ralfhandl
previously approved these changes
May 16, 2025
mikepizzo
reviewed
May 28, 2025
| @@ -476,14 +476,14 @@ greater MAY include nested entities and entity references that specify | |||
| the full set of to be related entities, or a nested [delta | |||
| payload](#DeltaPayloads) representing the related entities that have | |||
| been added, removed, or changed. Such a request is referred to as a | |||
| "deep update". If the nested collection is represented identical to an | |||
| "deep upsert". If the nested collection is represented identical to an | |||
There was a problem hiding this comment.
might be better to keep "deep update" to align with vocab, since it also includes deletes.
mikepizzo
reviewed
May 28, 2025
| @@ -701,7 +701,7 @@ through a navigation property path binding [#OData-CSDL#NavigationPropertyPathBi | |||
| or through the presence of a context URL within the payload; | |||
| if the service is unable to determine it, it MUST fail the request. | |||
|
|
|||
| Upserts are not supported against entities whose keys' values are | |||
| Upsert requests MUST NOT be treated as inserts of entities whose keys' values are | |||
There was a problem hiding this comment.
it's really can not -- there is no way to specify the url of an entity whose key is generated by the service and does not yet exist. The MUST comes in the following line.
ralfhandl
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2060