-
Notifications
You must be signed in to change notification settings - Fork 33
ts-web/rt: add missing events and error codes (with grep script) #2285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-oasis-sdk canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2285 +/- ##
=======================================
Coverage 53.96% 53.96%
=======================================
Files 163 163
Lines 12333 12333
=======================================
Hits 6656 6656
Misses 5677 5677 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lukaw3d
commented
Jul 29, 2025
console.log('missing methods:\n', grepResult) | ||
console.log('not checked: <module>.Parameters') | ||
} | ||
methods() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This printed:
missing events:
core.ts:export const EVENT_GAS_USED_CODE = 1;
consensus_accounts.ts:export const EVENT_DELEGATE_CODE = 3;
consensus_accounts.ts:export const EVENT_UNDELEGATE_START_CODE = 4;
consensus_accounts.ts:export const EVENT_UNDELEGATE_DONE_CODE = 5;
extraneous events:
core.ts:export const EVENT_GAS_USED = 1;
missing errors:
roflmarket.ts:export const ERR_INVALID_ARGUMENT_CODE = 1;
roflmarket.ts:export const ERR_PROVIDER_ALREADY_EXISTS_CODE = 2;
roflmarket.ts:export const ERR_PROVIDER_NOT_FOUND_CODE = 3;
roflmarket.ts:export const ERR_FORBIDDEN_CODE = 4;
roflmarket.ts:export const ERR_PROVIDER_HAS_INSTANCES_CODE = 5;
roflmarket.ts:export const ERR_OUT_OF_CAPACITY_CODE = 6;
roflmarket.ts:export const ERR_OFFER_NOT_FOUND_CODE = 7;
roflmarket.ts:export const ERR_INSTANCE_NOT_FOUND_CODE = 8;
roflmarket.ts:export const ERR_TOO_MANY_QUEUED_COMMANDS_CODE = 9;
roflmarket.ts:export const ERR_PAYMENT_FAILED_CODE = 10;
roflmarket.ts:export const ERR_BAD_RESOURCE_DESCRIPTOR_CODE = 11;
roflmarket.ts:export const ERR_INVALID_INSTANCE_STATE_CODE = 12;
contracts.ts:export const ERR_ABORT_CODE = 20;
contracts.ts:export const ERR_STORAGE_KEY_TOO_LARGE_CODE = 21;
contracts.ts:export const ERR_STORAGE_VALUE_TOO_LARGE_CODE = 22;
contracts.ts:export const ERR_CRYPTO_MSG_TOO_LARGE_CODE = 23;
contracts.ts:export const ERR_CRYPTO_MALFORMED_PUBLIC_KEY_CODE = 24;
contracts.ts:export const ERR_CODE_DECLARES_MULTIPLE_SUB_VERSIONS_CODE = 25;
contracts.ts:export const ERR_CRYPTO_MALFORMED_PRIVATE_KEY_CODE = 26;
contracts.ts:export const ERR_CRYPTO_MALFORMED_KEY_CODE = 27;
contracts.ts:export const ERR_CRYPTO_MALFORMED_NONCE_CODE = 28;
contracts.ts:export const ERR_CRYPTO_KEY_DERIVATION_FUNCTION_FAILURE_CODE = 29;
contracts.ts:export const ERR_MODULE_USES_FLOATING_POINT_CODE = 30;
contracts.ts:export const ERR_CODE_DECLARES_TOO_MANY_FUNCTIONS_CODE = 31;
contracts.ts:export const ERR_CODE_DECLARES_TOO_MANY_LOCALS_CODE = 32;
evm.ts:export const ERR_FORBIDDEN_CODE = 1;
evm.ts:export const ERR_ERC20_INVALID_SENDER_CODE = 2;
evm.ts:export const ERR_ERC20_INVALID_RECEIVER_CODE = 3;
evm.ts:export const ERR_ERC20_INVALID_APPROVER_CODE = 4;
evm.ts:export const ERR_ERC20_INVALID_SPENDER_CODE = 5;
evm.ts:export const ERR_ERC20_INSUFFICIENT_BALANCE_CODE = 6;
evm.ts:export const ERR_ERC20_INSUFFICIENT_ALLOWANCE_CODE = 7;
evm.ts:export const ERR_FORBIDDEN_CODE = 7;
evm.ts:export const ERR_REVERTED_CODE = 8;
evm.ts:export const ERR_SIMULATION_TOO_EXPENSIVE_CODE = 9;
evm.ts:export const ERR_INVALID_SIGNED_SIMULATE_CALL_CODE = 10;
consensus.ts:export const ERR_UNDER_MIN_DELEGATION_AMOUNT_CODE = 6;
core.ts:export const ERR_MESSAGE_HANDLER_NOT_INVOKED_CODE = 8;
core.ts:export const ERR_FORBIDDEN_IN_SECURE_BUILD_CODE = 21;
core.ts:export const ERR_FORBIDDEN_CODE = 22;
core.ts:export const ERR_OVERSIZED_TRANSACTION_CODE = 23;
core.ts:export const ERR_EXPIRED_TRANSACTION_CODE = 24;
core.ts:export const ERR_READ_ONLY_TRANSACTION_CODE = 25;
core.ts:export const ERR_FUTURE_NONCE_CODE = 26;
core.ts:export const ERR_CALL_DEPTH_EXCEEDED_CODE = 27;
access.ts:export const ERR_NOT_AUTHORIZED_CODE = 1;
consensus_accounts.ts:export const ERR_INSUFFICIENT_BALANCE_CODE = 3;
consensus_accounts.ts:export const ERR_FORBIDDEN_CODE = 4;
rofl.ts:export const ERR_INVALID_ARGUMENT_CODE = 1;
rofl.ts:export const ERR_UNKNOWN_APP_CODE = 2;
rofl.ts:export const ERR_NOT_SIGNED_BY_RAK_CODE = 3;
rofl.ts:export const ERR_NOT_SIGNED_BY_EXTRA_KEY_CODE = 4;
rofl.ts:export const ERR_UNKNOWN_ENCLAVE_CODE = 5;
rofl.ts:export const ERR_UNKNOWN_NODE_CODE = 6;
rofl.ts:export const ERR_NODE_NOT_ALLOWED_CODE = 7;
rofl.ts:export const ERR_REGISTRATION_EXPIRED_CODE = 8;
rofl.ts:export const ERR_EXTRA_KEY_UPDATE_NOT_ALLOWED_CODE = 9;
rofl.ts:export const ERR_APP_ALREADY_EXISTS_CODE = 10;
rofl.ts:export const ERR_FORBIDDEN_CODE = 11;
rofl.ts:export const ERR_UNKNOWN_INSTANCE_CODE = 12;
rofl.ts:export const ERR_PLAIN_CALL_FORMAT_NOT_ALLOWED_CODE = 13;
rofl.ts:export const ERR_ENDORSEMENT_POLICY_TOO_DEEP_CODE = 14;
rofl.ts:export const ERR_ENDORSEMENT_POLICY_TOO_MANY_ATOMS_CODE = 15;
rofl.ts:export const ERR_POLICY_MAX_EXPIRATION_TOO_HIGH_CODE = 16;
extraneous errors:
contracts.ts:export const ERR_CALL_DEPTH_EXCEEDED_CODE = 16;
consensus_accounts.ts:export const ERR_INSUFFICIENT_WITHDRAW_BALANCE_CODE = 3;
core.ts:export const ERR_MESSAGE_NOT_HANDLED_CODE = 8;
core.ts:export const ERR_BATCH_GAS_OVERFLOW_CODE = 13;
core.ts:export const ERR_BATCH_OUT_OF_GAS_CODE = 14;
core.ts:export const ERR_FORBIDDEN_IN_SECURE_BUILD = 21;
core.ts:export const ERR_FORBIDDEN_BY_NODE_POLICY = 22;
missing methods:
consensus.AllDelegations
consensus.AllUndelegations
consensus.Delegate
consensus.Delegation
consensus.Delegations
consensus.Undelegate
consensus.Undelegations
core.ExecuteReadOnlyTx
rofl.DeriveKey
roflmarket.InstanceAccept
roflmarket.InstanceChangeAdmin
roflmarket.InstanceClaimPayment
roflmarket.InstanceRemove
roflmarket.InstanceUpdate
not checked: <module>.Parameters
kostko
approved these changes
Jul 29, 2025
github-actions bot
added a commit
that referenced
this pull request
Jul 30, 2025
…w/rt-err-codes ts-web/rt: add missing events and error codes (with grep script) 009c2a4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1938
Related #86