Add endSlot prop in AlertBox component #1978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
lubej
force-pushed
the
ml/add-end-slot-to-alert-box
branch
2 times, most recently
from
7e96f87 to
c1784d2
Compare
lubej
commented
Jun 19, 2024
Comment on lines
42
to
61
| <AlertBox | ||
| status="ok-weak" | ||
| justify="between" | ||
| endSlot={ | ||
| <span> | ||
| <Anchor | ||
| href={''} | ||
| target="_blank" | ||
| rel="noopener" | ||
| color="brand" | ||
| style={{ verticalAlign: 'middle' }} | ||
| > | ||
| <Text size="xsmall">{t('account.summary.viewAccountTxs', 'View account transactions')}</Text> | ||
| <FormNext color="brand" size="18px" /> | ||
| </Anchor> | ||
| </span> | ||
| } | ||
| > | ||
| {t('account.summary.someTxsInPendingState', 'Some transactions are currently in a pending state.')} | ||
| </AlertBox> |
There was a problem hiding this comment.
Satisfied my use case in #1954
lubej
requested review from
buberdds and
lukaw3d
and removed request for
buberdds
Closed
|
Will remove Add sample usage - REVERT and update snapshots after initial review. |
buberdds
reviewed
Jun 19, 2024
| > | ||
| <Box direction="row" gap="small" align="center"> | ||
| {props.icon && <Text color={color}>{props.icon}</Text>} | ||
| <Text size="xsmall" weight="bold" style={{ verticalAlign: 'middle' }}> |
There was a problem hiding this comment.
This is not needed as parent flexbox container takes care of alignment, right?
There was a problem hiding this comment.
Since I replaced size="12px" with size="xsmall", the later adds line-height css property. Thats why I wanted to make it centered - otherwise looks weird with different vertical paddings inside alert. It is not ideal, as you would have to do the same on the endSlot, but I just disliked that size was hardcoded.
lubej
force-pushed
the
ml/add-end-slot-to-alert-box
branch
2 times, most recently
from
f5ddac1 to
7cf2029
Compare
buberdds
approved these changes
Jun 19, 2024
lubej
force-pushed
the
ml/add-end-slot-to-alert-box
branch
from
7cf2029 to
4d7cfde
Compare
lubej
force-pushed
the
ml/add-end-slot-to-alert-box
branch
from
4d7cfde to
e4a7b2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.