Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/aut 3960/gapmatch cant remove asset #175

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

olga-kulish
Copy link
Contributor

@olga-kulish olga-kulish commented Nov 15, 2024

Related to https://oat-sa.atlassian.net/browse/AUT-3960
Related to https://oat-sa.atlassian.net/browse/TR-4217

Changes

  1. Remove Passage from CkEditor toolbar, because it's not supported and won't exist in the published delivery (https://oat-sa.atlassian.net/browse/TR-4217)
  2. Apply options.flushDeletingWidgetsOnDestroy from Fix/aut 3960/gapmatch cant remove asset extension-tao-itemqti#2624
    Add Image, remove Image, click outside interaction before "Undo?" notification on top disappears --> Image won't be removed.
  3. Before editor destroy, put all table widgets to sleep state.
    Case: Add table. Add content in cells. Click outside interaction → table content won’t be saved.
    Because Table widget does some modification on exiting Active state.

To test

On unit01. All PRs:

Copy link

github-actions bot commented Nov 15, 2024

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
0 0 0 0

Copy link

Version

Target Version 3.9.3
Last version 3.9.2

There are 0 BREAKING CHANGE, 0 feature, 3 fixes

@olga-kulish olga-kulish requested review from a team, oatymart and taopkorczak November 15, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant