Skip to content

Commit

Permalink
Merge pull request #1121 from oat-sa/fix/AUT-3679/platform-requiremen…
Browse files Browse the repository at this point in the history
…ts-tests-max-version-8.3.x

chore: allow max PHP version 8.3.x
  • Loading branch information
pnal authored Jun 20, 2024
2 parents 72df6b1 + 6d5d355 commit 89a4256
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/unit/ConfigurationTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public function testPHPRuntime()
$this->assertTrue($php->isOptional());

// max & min test.
$php = new \common_configuration_PHPRuntime('7.4', '8.1.x');
$php = new \common_configuration_PHPRuntime('7.4', '8.3.x');
$report = $php->check();

$this->assertEquals($report->getStatus(), \common_configuration_Report::VALID);
Expand Down Expand Up @@ -175,7 +175,7 @@ public function testPHPExtension()
$report = $ext->check();
$this->assertEquals($report->getStatus(), \common_configuration_Report::VALID);

$ext->setMax('8.2');
$ext->setMax('8.3.x');
$report = $ext->check();
$this->assertEquals($report->getStatus(), \common_configuration_Report::VALID);

Expand Down Expand Up @@ -322,7 +322,7 @@ public function testSimpleComponentCollection()

public function testComponentFactory()
{
$component = \common_configuration_ComponentFactory::buildPHPRuntime('5.0', '8.1.x', true);
$component = \common_configuration_ComponentFactory::buildPHPRuntime('5.0', '8.3.x', true);
$this->assertInstanceOf(\common_configuration_PHPRuntime::class, $component);
$this->assertEquals($component->getMin(), '5.0');
// 5.5.x will be replaced internally
Expand Down Expand Up @@ -365,7 +365,7 @@ public function testComponentFactory()
$this->assertInstanceOf(\common_configuration_Report::class, $report);
$this->assertEquals($report->getStatus(), \common_configuration_Report::VALID);

$array = ['type' => 'PHPRuntime', 'value' => ['min' => '5.0', 'max' => '8.1.x', 'optional' => true]];
$array = ['type' => 'PHPRuntime', 'value' => ['min' => '5.0', 'max' => '8.3.x', 'optional' => true]];
$component = \common_configuration_ComponentFactory::buildFromArray($array);
$this->assertInstanceOf(\common_configuration_PHPRuntime::class, $component);
$this->assertEquals($component->getMin(), '5.0');
Expand Down

0 comments on commit 89a4256

Please sign in to comment.