refactor: add isEmpty method, test it

oat-sa · Oct 7, 2021 · a7208a2 · a7208a2
1 parent 5c758c8
commit a7208a2
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/core/resource/DependsOnPropertyCollection.php b/core/resource/DependsOnPropertyCollection.php
@@ -45,6 +45,11 @@ static function (core_kernel_classes_Property $property) {
         );
     }
 
+    public function isEmpty(): bool
+    {
+        return $this->count() === 0;
+    }
+
     private function areArraysEqual(array $array1, array $array2): bool
     {
         return empty(array_diff($array1, $array2)) && empty(array_diff($array2, $array1));

diff --git a/test/unit/core/resource/DependsOnPropertyCollectionTest.php b/test/unit/core/resource/DependsOnPropertyCollectionTest.php
@@ -80,4 +80,12 @@ public function testGetPropertyUris(): void
         $this->sut->append($secondProperty);
         $this->assertEquals(['firstProperty', 'secondProperty'], $this->sut->getPropertyUris());
     }
+
+    public function testIsEmpty(): void
+    {
+        $this->assertTrue($this->sut->isEmpty());
+
+        $this->sut->append('value');
+        $this->assertFalse($this->sut->isEmpty());
+    }
 }