fix: creating a directory for a service container #1059
Conversation
Version
There are 0 BREAKING CHANGE, 0 feature, 1 fix |
| @@ -101,6 +101,10 @@ public function forceBuild(): ContainerInterface | |||
| return $this->legacyContainer; | |||
| } | |||
|
|
|||
| if (!file_exists($this->cachePath)) { | |||
There was a problem hiding this comment.
I think we are trying to solve an infra issue in the application.
An env without the cache dir created is the problem, so the infra deployment should make sure it is created with right permissions before deploy anything
So we should solve this on infra level as we do not have the same issue with exnterprise customers, so probably there the pipeline is correct.
There was a problem hiding this comment.
If we sill want to create permissions here, we need to also validate if we have write permissions to create it and treat exception properly in case of no permissions, please :)
Thanks!
There was a problem hiding this comment.
As we discussed in out call we can use oat\oatbox\cache\SetupFileCache to create the directory in a previous step before calling container warmup command.
There was a problem hiding this comment.
Yeah, thank you for the discussion. It seems like the problem with the pipeline has broader implications than I initially thought. That's why I think to create one more script similar to install or update which will take care of those things. Please check it out oat-sa/tao-core#3870. I decided not to put it inside the cache warmer itself because it is not his responsibility and in case we would change the pipeline later, we would still be able to use the application cache warmer without any modifications.
I'm closing this PR though as it is not needed anymore.
Goal
Make sure cache directory exists before creating a service container file. This way we can ensure no error happen during later steps.
Changelog
How to test / use
datadirectoryphp index.php oat\generis\scripts\tools\ContainerCacheWarmup