fix: add retryTask for all exceptions #3752
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version
There are 0 BREAKING CHANGE, 0 feature, 2 fixes |
Codecov Report
@@ Coverage Diff @@
## develop #3752 +/- ##
==========================================
Coverage 27.31% 27.32%
- Complexity 10757 10758 +1
==========================================
Files 920 920
Lines 32073 32082 +9
==========================================
+ Hits 8762 8767 +5
- Misses 23311 23315 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Hey, can we also fix PHP CS mentioned on CIs? |
pnal
requested changes
Mar 1, 2023
| @@ -39,6 +39,7 @@ public function linkTaskToQueue($queueName); | |||
| /** | |||
There was a problem hiding this comment.
public const SERVICE_ID = 'tao/webhookTaskService';
add constant visibility keyword on line 30
wazelin
approved these changes
Apr 18, 2023
wazelin
requested changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some cases related to remote publications, webhook can be failed because delivery is not ready yet.
We can manage all those retries using
retryMaxoption in the webhookRegistry.conf.php if it will be needed.We need also backport it to v51.0.3