Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix copy of copied classes #3858

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

tikhanovichA
Copy link
Contributor

@tikhanovichA tikhanovichA commented Jul 26, 2023

https://oat-sa.atlassian.net/browse/ADF-1545

We need to fix the possibility of copying already copied classes.

How to test:

  1. Go to items and create a new folder/class
  2. Copy this class
  3. Try to copy the folder you got in step 2

After switching to the new version cache should be deleted to generate a new DI cache

@github-actions
Copy link

Version

Target Version 53.4.1
Last version 53.4.0

There are 0 BREAKING CHANGE, 0 feature, 1 fix

@codecov-commenter
Copy link

Codecov Report

Merging #3858 (a4db567) into develop (3ce1ff4) will not change coverage.
Report is 7 commits behind head on develop.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #3858   +/-   ##
==========================================
  Coverage      27.58%   27.58%           
  Complexity     10972    10972           
==========================================
  Files            922      922           
  Lines          33900    33900           
==========================================
  Hits            9351     9351           
  Misses         24549    24549           

Copy link
Contributor

@hectoras hectoras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced the issue locally, and then verified the change solves it 💪

  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • New code is covered by tests (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • Acceptance criteria are respected
  • Kitchen links are not exposed in the description

@tikhanovichA tikhanovichA merged commit f836655 into develop Jul 26, 2023
4 checks passed
@tikhanovichA tikhanovichA deleted the fix/ADF-1545/copy-of-copied-classes branch July 26, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants