REL-1198: List value URI definition should work with neo4j RDF storage. #3908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unctionality to fetch lists data.
vbyndych
force-pushed
the
feat/REL-1198/list-neo4j
branch
from
9dcf98e
to
ba0ca3a
Compare
Base automatically changed from
feat/REL-1197/rdf-import-export-neo4j
to
develop
October 20, 2023 14:43
augustas
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Working well for me. Just need to update dependency to generis
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Changelog is updated according to changes (if applicable)
- Documentation is updated according to changes (if applicable)
vbyndych
force-pushed
the
feat/REL-1198/list-neo4j
branch
from
b1049d1
to
05f300b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #3908 +/- ##
=============================================
- Coverage 27.55% 27.36% -0.20%
+ Complexity 10976 10968 -8
=============================================
Files 922 922
Lines 33910 33810 -100
=============================================
- Hits 9345 9251 -94
+ Misses 24565 24559 -6
☔ View full report in Codecov by Sentry. |
Version
There are 0 BREAKING CHANGE, 1 feature, 1 fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
List value URIs can be modified via user interface. Yet implementation is modifying SQL statements table directly, and would not work with neo4j RDF storage.
Changelog
How to test / use
Lists are used in many places but the easiest way to test them is lists settings page.
Dependencies