Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: display asset export errors #3920

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

pribi
Copy link
Contributor

@pribi pribi commented Oct 31, 2023

Ticket: https://oat-sa.atlassian.net/browse/ADF-961

What's Changed

  • Display Asset Export errors in the export report display block.

TODO

  • Unit tests
  • E2E tests
  • Update composer with packages

How to test

  • Create a new Passage Asset.
  • In Authoring Edit the Asset and embed and image.
  • Delete the embedded image - so there will be a broken link in the Asset.
  • Try to Export the Asset.
  • You should be able to notice the errors in the export report display block.
    error

@pribi pribi marked this pull request as draft November 1, 2023 09:27
@pribi pribi marked this pull request as ready for review November 2, 2023 11:20
Copy link

github-actions bot commented Nov 2, 2023

Version

Target Version 53.12.0
Last version 53.11.3

There are 0 BREAKING CHANGE, 2 features, 0 fix

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a4eced) 27.36% compared to head (b8a7675) 27.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3920   +/-   ##
==========================================
  Coverage      27.36%   27.36%           
  Complexity     10968    10968           
==========================================
  Files            922      922           
  Lines          33810    33810           
==========================================
  Hits            9251     9251           
  Misses         24559    24559           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pribi pribi merged commit 450800c into develop Nov 3, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants