Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format microtime() to DateTimeInterface::RFC3339_EXTENDED function #3928

Conversation

…xecution->getFinishTime() on delivery finish
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5aceedb) 27.33% compared to head (f0a15e5) 27.35%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3928      +/-   ##
=============================================
+ Coverage      27.33%   27.35%   +0.02%     
- Complexity     10969    10971       +2     
=============================================
  Files            922      922              
  Lines          33803    33810       +7     
=============================================
+ Hits            9241     9250       +9     
+ Misses         24562    24560       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Version

Target Version 53.13.0
Last version 53.12.1

There are 0 BREAKING CHANGE, 2 features, 3 fixes

Copy link
Contributor

@pnal pnal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

@Karol-Stelmaczonek Karol-Stelmaczonek merged commit 3c01dcf into develop Nov 27, 2023
5 of 6 checks passed
Karol-Stelmaczonek added a commit that referenced this pull request Nov 28, 2023
#3928)

* fix: refactor and move format function to Date helper, pass deliveryExecution->getFinishTime() on delivery finish

* feat: add unit test

* feat: add unit test

* fix: codestyle

* fix: add new data

(cherry picked from commit 3c01dcf)
Karol-Stelmaczonek added a commit that referenced this pull request Feb 9, 2024
#3928)

* fix: refactor and move format function to Date helper, pass deliveryExecution->getFinishTime() on delivery finish

* feat: add unit test

* feat: add unit test

* fix: codestyle

* fix: add new data

(cherry picked from commit 3c01dcf)
Karol-Stelmaczonek added a commit that referenced this pull request Feb 9, 2024
…tmicrotime

Add format microtime() to DateTimeInterface::RFC3339_EXTENDED function (#3928)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants