fix google tag rendering #3978
fix google tag rendering #3978
Conversation
poyuki
requested review from
tikhanovichA,
kilatib,
wazelin and
andreluizmachado
Front-end summary Node 18
|
helpers/Layout.php
Outdated
| $gaTag = $_ENV['GA_TAG']; | ||
| $environment = $_ENV['NODE_ENV'] === 'production' ? 'Production' : 'Internal'; |
There was a problem hiding this comment.
We need to check if the keys are set in $_ENV now before accessing them to avoid undefined-key warnings.
There was a problem hiding this comment.
actually $_ENV['GA_TAG'] will be null if it not define as far as I can see
There was a problem hiding this comment.
Yes. But it will also raise a PHP warning :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3978 +/- ##
==========================================
Coverage 27.31% 27.31%
Complexity 11021 11021
==========================================
Files 927 927
Lines 33965 33965
==========================================
Hits 9276 9276
Misses 24689 24689 ☔ View full report in Codecov by Sentry. |
Version
There are 0 BREAKING CHANGE, 0 feature, 1 fix |
There was a problem hiding this comment.
Well done, @poyuki!
Let's merge and port to the March release:
- On top of https://github.com/oat-sa/tao-core/releases/tag/v54.2.2
- Then as part of TAO Community
- Then include TAO Community to https://github.com/oat-sa/taocloud-ami-luoss/blob/release-2024.03.2/composer.json#L103
Oh, and after that, April release will have to be updated too of course. I guess we can just set the latest tao-core version there.
TR-6036
Summary
This PR aim to address issue with rendering of GA tag in some environments
Development impact
<? ?>(which at least onuat.eu.premium.lab.taocloud.orgconverted into html comment)$_ENVinstead ofgetenv(usage of which discouraged by dotenv lib documentation )