-
Notifications
You must be signed in to change notification settings - Fork 10
remove restrictions to not allow MAC-based algorithms #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 1. The JWT MAY contain other claims. All claims that are not understood by implementations MUST be ignored. | ||
|
|
||
| 2. The JWT MUST be digitally signed using an asymmetric cryptographic algorithm. The authorization server MUST reject the JWT if it is using a Message Authentication Code (MAC) based algorithm. The authorization server MUST reject JWTs with an invalid signature. | ||
| 2. The JWT MUST be digitally signed using an asymmetric cryptographic algorithm. The authorization server MUST reject JWTs with an invalid signature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would still not allow MAC I believe?
Something like this is used in JWT RFC:
[...] be digitally signed or integrity protected with a Message Authentication Code (MAC) [...]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The question is if we want to allow public key derived MACs or MACs in general? The former relies on asymmetric mechanism and would be included imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't thought too much about this yet, but my gut feeling would be to allow MAC - people need to understand their deployments and requirements, but I could see something like this used in a context where attestation server and AS are operated by the same entity.
I would agree for the PoP (to not allow MACs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @c2bo there are lots of Oauth deployments that use MAC to say secure the AT and I think the Client attestation could be treated somewhat similar in certain deployments but asymmetric is required for the PoP.
Co-authored-by: Christian Bormann <[email protected]>
Closes #130