Skip to content

Incorporate feedback from Rifaat #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2025
Merged

Conversation

c2bo
Copy link
Member

@c2bo c2bo commented May 19, 2025

@c2bo c2bo requested review from tplooker and paulbastian as code owners May 19, 2025 07:14
@c2bo c2bo requested a review from rifaat-shekh-yusef May 19, 2025 11:50
Copy link

@rifaat-shekh-yusef rifaat-shekh-yusef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Christian!
Looks good to me.

Copy link
Collaborator

@tplooker tplooker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment otherwise LGTM

@paulbastian paulbastian merged commit 87e7da2 into main May 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants