bug(#3708): Required tojo methods for caching xmir-to-phi/phi-to-xmir goals#3778
Open
ArtemGet wants to merge 10 commits intoobjectionary:masterfrom
Open
bug(#3708): Required tojo methods for caching xmir-to-phi/phi-to-xmir goals#3778ArtemGet wants to merge 10 commits intoobjectionary:masterfrom
ArtemGet wants to merge 10 commits intoobjectionary:masterfrom
Conversation
yegor256
reviewed
Dec 29, 2024
| return file.toString().substring( | ||
| this.parent.toString().length() + 1 | ||
| ).replaceAll(".eo$", "").replace(File.separator, "."); | ||
| ).replaceAll(this.extension, "").replace(File.separator, "."); |
Member
There was a problem hiding this comment.
@ArtemGet this looks pretty dangerous. What if this.extension will be equal to ( -- you will get runtime exception here. Try using Pattern.quote().
Contributor
Author
There was a problem hiding this comment.
@yegor256 Agreed, add Pattern.quote and tests.
Member
|
@ArtemGet please merge current |
Contributor
Author
|
@maxonfjvipon Is OPTIMIZED attribute not present now? I am using it in xmir-to-phi cache. |
Member
Contributor
Author
|
@maxonfjvipon Changed OPTIMIZED to XMIR. Could you check please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #3708