Skip to content

Conversation

@danben2904
Copy link

No description provided.

@yegor256
Copy link
Member

yegor256 commented Oct 8, 2025

@danben2904 fixing more than one issue in a pull request is a bad practice. Moreover, where are the tests? How do you know the problems were fixed?

@danben2904
Copy link
Author

@yegor256 added tests, can you check please?

@danben2904
Copy link
Author

@yegor256 can you check this out? I also implemented markdown support and tests for it(Issue #718)(I know it's a bad practice, sorry, but otherwise I would've had to face difficulties merging two very different versions of the code)

@danben2904
Copy link
Author

@yegor256 can you please review the changes I made to docs?

@yegor256
Copy link
Member

@danben2904 please, submit one PR per issue. We can't review all together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants