Skip to content

fix: stop adding to wait group on shutdown #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ibuildthecloud merged 1 commit into from
Apr 9, 2025
Merged

fix: stop adding to wait group on shutdown #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pkg/runtime/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,13 +263,19 @@ func (c *controller) runWorkers(ctx context.Context, workers int) {

for {
obj, shutdown := queue.Get()

if shutdown {
return
}

// Acquire from the semaphore
running <- struct{}{}

if queue.ShuttingDown() {
// If we acquired after the workers were shutdown,
// then drop this object and return instead of trying to add to the wait group, which will panic.
return
}

wait.Add(1)

go func() {
Expand Down