enhance: add controller handlers to delete unauthorized MCPServers and MCPServerInstances #3276
+137
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d MCPServerInstances Signed-off-by: Grant Linville <[email protected]>
njhale
reviewed
Jul 1, 2025
Comment on lines
+307
to
+310
| user, err := h.gatewayClient.UserByID(req.Ctx, server.Spec.UserID) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to get user %s: %w", server.Spec.UserID, err) | ||
| } |
There was a problem hiding this comment.
Does the server get cleaned up by another controller if the user no longer exists? If not, should we clean it up here.
There was a problem hiding this comment.
Good call. I need to update the UserDelete controller route to delete the servers that belong to the user. I'll take care of that shortly.
Comment on lines
+367
to
+370
| user, err := h.gatewayClient.UserByID(req.Ctx, instance.Spec.UserID) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to get user %s: %w", instance.Spec.UserID, err) | ||
| } |
There was a problem hiding this comment.
the instances will get deleted when the servers get deleted because they have a DeleteRef to the server
Signed-off-by: Grant Linville <[email protected]>
njhale
approved these changes
Jul 2, 2025
thedadams
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.