Enhance: support prompting user to chosse pat/oauth#536
Merged
StrongMonkey merged 1 commit intoobot-platform:mainfrom Mar 31, 2025
Merged
Enhance: support prompting user to chosse pat/oauth#536StrongMonkey merged 1 commit intoobot-platform:mainfrom
StrongMonkey merged 1 commit intoobot-platform:mainfrom
Conversation
tybalex
approved these changes
Mar 27, 2025
oauth2/main.go
Outdated
| return "", fmt.Errorf("promptForSelect: failed to unmarshal prompt response: %w", err) | ||
| } | ||
|
|
||
| authType := authType(m[fieldName]) |
Contributor
There was a problem hiding this comment.
Suggested change
| authType := authType(m[fieldName]) | |
| selectedAuthType := authType(m[fieldName]) |
Optional. I was just confused by the variable name lol, as it is also a custom type
156b7bd to
717ce77
Compare
g-linville
approved these changes
Mar 27, 2025
oauth2/go.mod
Outdated
|
|
||
| go 1.23.0 | ||
|
|
||
| replace github.com/gptscript-ai/go-gptscript => ../../go-gptscript |
Member
There was a problem hiding this comment.
make sure you remove this before merging
Signed-off-by: Daishan Peng <daishan@acorn.io>
717ce77 to
6c9753d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to do prompting to user to choose pat/oauth.