enhance: browser: combine get and download tools #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
g-linville
commented
Apr 24, 2025
Comment on lines
+52
to
+58
| const run = await client.run("github.com/obot-platform/tools/workspace-files/tool.gpt", { | ||
| subTool: "workspace_read", | ||
| workspace: workspaceId, | ||
| input: JSON.stringify({ | ||
| filename: fileName | ||
| }) | ||
| }) |
There was a problem hiding this comment.
Is this the right way to do this? Or would it be better to use a relative path back to the workspace-files directory?
There was a problem hiding this comment.
IIUC, this will get remapped to the local directory since we're setting GPTSCRIPT_TOOL_REMAP in the docker image anyway... Although I'm not actually sure if that gets plumbed down to tool executions
There was a problem hiding this comment.
I'd prefer this as it's the gptscript API, though I 'v seen Daishan used relative path to directly call the tool in a subprocess.
Signed-off-by: Grant Linville <[email protected]>
g-linville
requested review from
drpebcak,
thedadams,
njhale,
tybalex and
StrongMonkey
njhale
approved these changes
Apr 24, 2025
thedadams
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for obot-platform/obot#2604