Merged
Conversation
cjellick
reviewed
Apr 25, 2025
cjellick
reviewed
Apr 25, 2025
Signed-off-by: Taylor Price <[email protected]>
cjellick
approved these changes
Apr 29, 2025
thedadams
approved these changes
Apr 29, 2025
Comment on lines
+26
to
+27
| username: ${{ secrets.GHCR_USERNAME }} | ||
| password: ${{ secrets.GHCR_TOKEN }} |
Contributor
There was a problem hiding this comment.
Do we need this? Can we use the token passed to the action?
Contributor
Author
There was a problem hiding this comment.
hmm.. we probably could get rid of these yeah. ill follow up on that in a separate set of prs
Contributor
There was a problem hiding this comment.
Same question here about using the GitHub token passed to the action instead of a secret.
| cd /obot-tools | ||
|
|
||
| if [ ! -e workspace-provider ]; then | ||
| git clone --depth=1 https://github.com/gptscript-ai/workspace-provider |
Contributor
There was a problem hiding this comment.
nit: would be nice to be able to change these with an env var or something.
Contributor
Author
There was a problem hiding this comment.
yeah ive got that marked down as a future enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Taylor Price [email protected]