fix: detect OAI reasoning models, and have their temperatures fixed to 1.0 #653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tybalex
changed the title
tybalex
requested review from
cjellick,
drpebcak,
thedadams,
njhale,
StrongMonkey and
g-linville
tybalex
changed the title
thedadams
reviewed
May 13, 2025
Co-authored-by: Donnie Adams <[email protected]>
Co-authored-by: Donnie Adams <[email protected]>
Co-authored-by: Donnie Adams <[email protected]>
g-linville
approved these changes
May 14, 2025
thedadams
approved these changes
May 15, 2025
tybalex
added a commit
to tybalex/otto8-tools
that referenced
this pull request
May 17, 2025
…o 1.0 (obot-platform#653) * fix: detect OAI reasoning models, and have their temperature == 1.0 * fix: remove o1 models(except o1 itself) from chat model list * Update openai-model-provider/openaiproxy/proxy.go Co-authored-by: Donnie Adams <[email protected]> * Update openai-model-provider/openaiproxy/proxy.go Co-authored-by: Donnie Adams <[email protected]> * Update openai-model-provider/proxy/rewrite.go Co-authored-by: Donnie Adams <[email protected]> * Update proxy.go --------- Co-authored-by: Donnie Adams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will take care of obot-platform/obot#2862 (comment)
Also added o3 and o4 series models to chat models, removed o1-mini/o1-preview/o1-pro