Skip to content

Conversation

@imadreamerboy
Copy link
Contributor

This pull request introduces a new feature to configure how the Clipper UI opens, adds support for side panel functionality in Chromium-based browsers and Firefox, and updates the settings and context menu accordingly. The most important changes are grouped below by theme.

New Feature: Clipper UI Open Mode

  • Added a new clipperOpenMode setting to allow users to choose how the Clipper UI opens: as a popup (default) or in a side panel (Chromium-only). This includes updates to the settings interface, dropdown initialization, and saving/loading logic. (src/types/types.ts [1] src/utils/storage-utils.ts [2] [3] [4] [5] [6] src/managers/general-settings.ts [7] [8] [9] src/settings.html [10]

Side Panel and Sidebar Support

  • Added support for opening the Clipper UI in the side panel for Chromium-based browsers using the Chrome API. (src/background.ts [1] [2] [3]

Context Menu Updates

  • Updated context menus to include options for opening the side panel in Chromium-based browsers and the sidebar in Firefox. (src/background.ts [1] [2]

Localization Updates

  • Added new localization strings for the clipperOpenMode setting and a Firefox-specific permissions message. (src/_locales/en/messages.json [1] [2]

Highlighter Integration

  • Updated the highlighter's clip button behavior to respect the clipperOpenMode setting and handle errors based on the browser type. (src/utils/highlighter.ts [1] [2]

…bar, this fixes the issue with vivaldi where we can't call the popup via the toolbar.

todo: remove debug prints, clean up settings, add translation strings
…) issue here is that it can't be called without user action.
@imadreamerboy
Copy link
Contributor Author

I tested it with Chrome and Vivaldi.

For Firefox i added the support for to use obsidian webclipper in the sidebar via changing the permissions in the manifest.
The main issue with clipper highlights and the obsidian toolbar in firefox is that it's unable to open the sidebar based on non-user behaviour.

This PR addresses: #437 #285 (mabye even #430 since it's working and i was not able to replicate the issue)

@imadreamerboy
Copy link
Contributor Author

image image

I changed the way i handled those issues.

I added a new hotkey option where users can open the side panel with.

In addition, i changed the dropdown to a toggle and made it apply globally so every clipping action (normal clipper, highlight etc) opens in the sidebar when chosen.

I tried some ways for firefox but ultimately gave up because it's too restrictive with the sidebar. You can still use the shortcut or open it manually but the same automatism that is implemented in chromium won't work. So it defaults to the popup.

Tested with Edge, Chrome, Vivaldi and Firefox.

@kepano
Copy link
Collaborator

kepano commented Aug 11, 2025

I am currently working on an alternate way to open the extension, see #567. This is still WIP but it forces the extension to open within the page itself which will work better across various browsers, and also add some other benefits like being able to run Interpreter on multiple pages at the same time.

The PR also adds an "Open behavior" dropdown similar to what you have. I think it would be best to build off of that once I merge it. We can "Side panel" as one of the options there.

@imadreamerboy
Copy link
Contributor Author

sounds good! Let me know if you could need any assistance otherwise I will wait for it to be merged and add the sidebar functionality (unless you include it in your pr which is totally fine)

@kepano
Copy link
Collaborator

kepano commented Aug 14, 2025

The PR has been merged

@kepano
Copy link
Collaborator

kepano commented Aug 14, 2025

Closing this PR you can reopen a new one since this will likely require some significant changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants