-
Notifications
You must be signed in to change notification settings - Fork 278
Fix: Sidebar behaviour for Vivaldi #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…bar, this fixes the issue with vivaldi where we can't call the popup via the toolbar. todo: remove debug prints, clean up settings, add translation strings
…) issue here is that it can't be called without user action.
|
I tested it with Chrome and Vivaldi. For Firefox i added the support for to use obsidian webclipper in the sidebar via changing the permissions in the manifest. This PR addresses: #437 #285 (mabye even #430 since it's working and i was not able to replicate the issue) |
…andle action click behavior and respond to settings changes.
…support for firefox because of restrictions, it defaults to popup)
|
I am currently working on an alternate way to open the extension, see #567. This is still WIP but it forces the extension to open within the page itself which will work better across various browsers, and also add some other benefits like being able to run Interpreter on multiple pages at the same time. The PR also adds an "Open behavior" dropdown similar to what you have. I think it would be best to build off of that once I merge it. We can "Side panel" as one of the options there. |
|
sounds good! Let me know if you could need any assistance otherwise I will wait for it to be merged and add the sidebar functionality (unless you include it in your pr which is totally fine) |
|
The PR has been merged |
|
Closing this PR you can reopen a new one since this will likely require some significant changes. |


This pull request introduces a new feature to configure how the Clipper UI opens, adds support for side panel functionality in Chromium-based browsers and Firefox, and updates the settings and context menu accordingly. The most important changes are grouped below by theme.
New Feature: Clipper UI Open Mode
clipperOpenModesetting to allow users to choose how the Clipper UI opens: as a popup (default) or in a side panel (Chromium-only). This includes updates to the settings interface, dropdown initialization, and saving/loading logic. (src/types/types.ts[1]src/utils/storage-utils.ts[2] [3] [4] [5] [6]src/managers/general-settings.ts[7] [8] [9]src/settings.html[10]Side Panel and Sidebar Support
src/background.ts[1] [2] [3]Context Menu Updates
src/background.ts[1] [2]Localization Updates
clipperOpenModesetting and a Firefox-specific permissions message. (src/_locales/en/messages.json[1] [2]Highlighter Integration
clipperOpenModesetting and handle errors based on the browser type. (src/utils/highlighter.ts[1] [2]