-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add plugin: OneiroMetrics #6715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add plugin: OneiroMetrics #6715
Conversation
Adding custom-selected-word-count
Fix JSON syntax in community-plugins.json
JSON syntax correction
This reverts commit af1c587.
Hello!I found the following issues in your plugin submission Errors: ❌ Plugin name mismatch, the name in this PR ( This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Required[1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21][22][23][24][25][26][27][28][29][30] and more :You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets. [1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21][22][23][24][25][26][27][28][29][30] and more :Using [1][2][3][4][5][6][7][8]:You should change all instances of [1][2][3]:Obsidian's configuration directory isn't necessarily [1][2][3][4][5]:This class is only available on desktop, which means that this will throw errors on mobile (that's a problem since you have [1][2]:You should not cast this, instead use a [1][2]:You should not cast this, instead use a [1]:We recommend against providing a default hotkey when possible. The reason being that it's easy to pick a hotkey that a user already has configured and they could get confused when that key doesn't do what they expect. Also, it's hard choosing a safe default hotkey that's available for all operating systems. [1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21][22][23][24][25][26][27][28][29][30] and more :You should consider limiting the number of Optional[1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21][22][23][24][25][26][27][28][29][30] and more :Casting to [1][2]:Use Do NOT open a new PR for re-validation. |
Just added a new release (0.16.2) that includes fixes to an invisible textarea issue, and to a template import issue. |
In a new release (0.16.3), I have addressed the issues listed by the Review Bot above:
Let me know if I missed anything! |
Adding OneiroMetrics!
I am submitting a new Community Plugin
Repo URL
Link to my plugin: https://github.com/banisterious/obsidian-oneirometrics
Release Checklist
main.js
manifest.json
styles.css
(optional)v
)id
in mymanifest.json
matches theid
in thecommunity-plugins.json
file.I have given proper attribution to these other projects in my
README.md
.