-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add plugin: Variant Editor #6718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
add Variant Editor Plugin
Hello!I found the following issues in your plugin submission Errors: ❌ The This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Required[1][2][3][4][5][6][7][8][9][10][11][12]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets. [1][2][3][4]:Using [1]:We recommend against providing a default hotkey when possible. The reason being that it's easy to pick a hotkey that a user already has configured and they could get confused when that key doesn't do what they expect. Also, it's hard choosing a safe default hotkey that's available for all operating systems. Optional[1][2][3]:Casting to Do NOT open a new PR for re-validation. |
Addressed default hotkey and innerHTML and many of the avoid assigning styles via javascript |
/skip |
Maybe I should have waited for it to go to the second round before writing the /skip... Not sure. Let me know if this can be reviewed or the labels can be updated to ready to review by a human @ObsidianReviewBot @farcaller @muness @dpickett |
Oh nice, the labels were updated after a couple hours. Sorry for the impatience! |
add Variant Editor Plugin
I am submitting a new Community Plugin
Repo URL
Link to my plugin: https://github.com/kunalJa/VariantEditor
Release Checklist
main.js
manifest.json
styles.css
(optional)v
)id
in mymanifest.json
matches theid
in thecommunity-plugins.json
file.I have given proper attribution to these other projects in my
README.md
.