Skip to content

Add audio buffer option to audio config#53

Merged
RytoEX merged 1 commit intoobsproject:masterfrom
oviano:audio-buffer-option
Feb 4, 2025
Merged

Add audio buffer option to audio config#53
RytoEX merged 1 commit intoobsproject:masterfrom
oviano:audio-buffer-option

Conversation

@oviano
Copy link
Contributor

@oviano oviano commented Jun 4, 2023

Description

This adds an option to set the audio buffer, rather than be forced to use 10ms.

Motivation and Context

I am trialing the library in a personal hobby project and I found that with a 10ms buffer, I was getting audio glitches so I needed to raise it. 80ms is apparently recommended by MSDN, and 50ms is the default used inside FFmpeg.

How Has This Been Tested?

Testing with my project shows the audio is more stable when I increase the buffer.

Types of changes

Tweak (non-breaking change to improve existing functionality)

Checklist:

My code has been run through clang-format.
I have read the contributing document.
My code is not on the master branch.
The code has been tested.
All commit messages are properly formatted and commits squashed where appropriate.
I have included updates to all appropriate documentation.

@Fenrirthviti
Copy link
Member

Please properly fill out the PR template instead of deleting it.

@Lain-B
Copy link
Collaborator

Lain-B commented Nov 9, 2024

For clarification, you say "more stable." Does that mean it's still unstable? What device are you observing this issue with? It would be good to have more information on the actual issue itself you're experiencing (unless you already filed an issue, in which case please make sure to link it).

@Lain-B
Copy link
Collaborator

Lain-B commented Nov 9, 2024

Oh geez this PR is really old, I'm really sorry it took so long to respond to this. I think this just flew over our heads a bit last year and we didn't put it on our task list for whatever reason at the time.

@oviano
Copy link
Contributor Author

oviano commented Nov 9, 2024

It’s ok, I long since stopped using the library anyway so feel free to close this if you like.

Copy link
Collaborator

@Lain-B Lain-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you're not using libdshowcapture anymore but this needs a minor API version before we merge. Otherwise it's fine though.

@RytoEX
Copy link
Member

RytoEX commented Jan 30, 2025

I know you're not using libdshowcapture anymore but this needs a minor API version before we merge. Otherwise it's fine though.

@Lain-B If we need to bump this before we merge, I can do that.

@RytoEX RytoEX changed the title Added audio buffer option to audio config Add audio buffer option to audio config Feb 4, 2025
@RytoEX RytoEX force-pushed the audio-buffer-option branch from f382534 to 654d45c Compare February 4, 2025 20:10
@RytoEX RytoEX merged commit b3cff2b into obsproject:master Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants