Expand panel shutdown event listener to all platforms #463
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This expands the previously introduced shutdown loop check for browser docks to Windows and macOS.
As a reminder, this solves a potential crash on shutdown if the user has many docks or heavy docks.
As this solution has a timeout (max 1 second per dock), I am much more comfortable expanding its usage to all platforms compared to the original solution.
Motivation and Context
I have a feeling that users on other platforms have been running into this issue, but because we don't provide CEF symbols (and because it occurs on shutdown) reports have been sporadic and/or lacking the necessary detail to track it down.
How Has This Been Tested?
Close browser docks manually and on shutdown, experience no crash.
Types of changes
Checklist: