Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run uploads in submodules, create empty language files & upgrade all packages #13

Merged
merged 12 commits into from Aug 13, 2023
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jan 17, 2023

Description

  • Increase reliability
  • Upgrade all packages for security
  • Make it possible to run the action in submodules (obs-browser, obs-websocket, ...)
  • Create empty language files for languages like en-GB to no longer make the log show warnings for missing language files
  • Add missing JSDoc
  • Remove handling for enc-amf
  • Generate reports simultaneously because reasons
  • Refactors

I wasn't happy with #12 and closed it. After force-pushing to the branch again I wasn't allowed to re-open it.

Motivation and Context

Security & reliability are important.

How Has This Been Tested?

By testing all scenarios I could come up with in a forked org on GitHub and a private Crowdin project + unit tests.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM self-assigned this Jan 17, 2023
@RytoEX
Copy link
Member

RytoEX commented Apr 17, 2023

Aside from the merge conflict due to #15, what's the blocker here? Is there any large risk of just merging this once the merge conflict is resolved? I'm not a huge fan of blocking dependency updates on a review of a larger rework.

@ghost ghost changed the title v3.0.0: Run uploads in submodules, create empty language files & upgrade all packages Run uploads in submodules, create empty language files & upgrade all packages Apr 19, 2023
Copy link
Member

@WizardCM WizardCM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally, the code looks even better than before. Just a couple minor notes.

src/download.ts Outdated Show resolved Hide resolved
.eslintrc Outdated Show resolved Hide resolved
src/download.ts Show resolved Hide resolved
src/download.ts Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Aug 13, 2023

@WizardCM Done.

@WizardCM WizardCM merged commit a18ecf5 into obsproject:main Aug 13, 2023
3 checks passed
@ghost
Copy link
Author

ghost commented Aug 13, 2023

Thank you. Merging this unlocked obsproject/obs-studio#8773.

@ghost ghost deleted the release/3.0.0 branch August 13, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants