-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run uploads in submodules, create empty language files & upgrade all packages #13
Conversation
Aside from the merge conflict due to #15, what's the blocker here? Is there any large risk of just merging this once the merge conflict is resolved? I'm not a huge fan of blocking dependency updates on a review of a larger rework. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally, the code looks even better than before. Just a couple minor notes.
The submodule was removed.
@WizardCM Done. |
Thank you. Merging this unlocked obsproject/obs-studio#8773. |
Description
I wasn't happy with #12 and closed it. After force-pushing to the branch again I wasn't allowed to re-open it.
Motivation and Context
Security & reliability are important.
How Has This Been Tested?
By testing all scenarios I could come up with in a forked org on GitHub and a private Crowdin project + unit tests.
Types of changes
Checklist: