Update Windows build script to use explicit package names #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatTheMav
force-pushed
the
windows-output-dir
branch
from
7a39a7e
to
ae10ea5
Compare
PatTheMav
force-pushed
the
windows-output-dir
branch
from
ae10ea5
to
f841c11
Compare
PatTheMav
force-pushed
the
windows-output-dir
branch
from
f841c11
to
b58a53b
Compare
PatTheMav
force-pushed
the
windows-output-dir
branch
2 times, most recently
from
63013b4
to
3d6d598
Compare
PatTheMav
force-pushed
the
windows-output-dir
branch
from
3d6d598
to
0c8c0ca
Compare
RytoEX
requested changes
Nov 15, 2023
PatTheMav
force-pushed
the
windows-output-dir
branch
from
0c8c0ca
to
1008481
Compare
RytoEX
reviewed
Nov 17, 2023
Default dependencies and Qt are separates package names that can be explicitly identified throughout the script and handled in explicit blocks.
PatTheMav
force-pushed
the
windows-output-dir
branch
from
1008481
to
5947689
Compare
PatTheMav
force-pushed
the
windows-output-dir
branch
from
5947689
to
cacdece
Compare
RytoEX
approved these changes
Dec 19, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the Windows build script to explicitly identify dependency "package names" (instead of inferring them implicitly).
Motivation and Context
Allows checking for package name globally and adopt different code paths for each package.
Prerequisite for #186 as caches generated by nightly runs are incompatible with that codebase otherwise.
This change adds new parameter
PackageNameto the build script which selects the kind of dependency package to build:dependencies(the default)qtffmpeg(added later in deps.ffmpeg: Switch Windows builds to native build toolchain #186)When the parameter is omitted, default Windows dependencies are built. If Qt is to be built
-PackageName qtneeds to be provided instead.How Has This Been Tested?
Needs to be tested on CI and later with #186 after merging and rebasing.
Types of changes
Checklist: