-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add uthash #203
Add uthash #203
Conversation
Is there a specific reason to include the other headers? We only need |
I just did it like a packager should do it since all the header are part of uthash. |
e33a5f7
to
cc3edad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good. I also agree with copying all related files to make it a "default" distribution.
The compiler will pull in files as needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine at a glance. Will merge when we get to a merge window.
61d0a75
to
732ec16
Compare
Description
Add uthash to obs-deps.
Yes, they should be installed in the include directory without any subdirectory to align with Linux distros.
Motivation and Context
Reduce in-tree vendored deps in OBS Studio repo.
How Has This Been Tested?
CI builds artifacts on my fork PR, they contain headers and license files.
Types of changes
Checklist: