Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps.qt: Backport option to disable native messagebox dialog #211

Closed

Conversation

gxalpha
Copy link
Member

@gxalpha gxalpha commented Sep 9, 2023

Description

Backports qt/qtbase@29b2506e which adds the option to disable native messageboxes on macOS.
Unfortunately, the native messageboxes were introduced in 6.5 but the option only exists in 6.6, which is why this backport is needed. To be able to differentiate the patched 6.5 from a normal one, the patch was amended to add a #define OBS_QT_NON_NATIVE_MESSAGEBOX_DIALOG that can then be checked against in OBS source code to check for the availability of the option.

Motivation and Context

Needed to make obsproject/obs-studio#9579 actually do something.

How Has This Been Tested?

Tested with a patched release of obs-deps and the changes in obsproject/obs-studio#9579.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@gxalpha
Copy link
Member Author

gxalpha commented Sep 10, 2023

This is not actually needed if we use some small hacks on obs-studio side.

@gxalpha gxalpha closed this Sep 10, 2023
@gxalpha gxalpha deleted the qt-disable-native-popup-option branch September 10, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant