Skip to content

frontend: Fix checked control button color not changing in System theme#12436

Open
shiina424 wants to merge 1 commit intoobsproject:masterfrom
shiina424:Fix-checked-control-button-color-not-changing
Open

frontend: Fix checked control button color not changing in System theme#12436
shiina424 wants to merge 1 commit intoobsproject:masterfrom
shiina424:Fix-checked-control-button-color-not-changing

Conversation

@shiina424
Copy link
Contributor

@shiina424 shiina424 commented Jul 26, 2025

Description

The control button colors do not change in the System theme.
I chose the button colors with consideration for the OS light and dark modes, but I don’t think they are perfect.
Given my current knowledge, it is difficult for me to make any further changes.
If a better solution exists, please feel free to close this PR.

This issue does not occur in version 31.0.4.
It appears to have been caused by the following changes:
76e1818 and 28960a4

Before (version 31.0.4)
Note: OBS does not switch to dark mode even when the OS is set to dark mode.

Before-31-0-4.mp4

Before (OS Color Light Mode)

Before-system-light.mp4

After (OS Color Light Mode)

os-color-light

rgb 203, 226, 248 (Before)

After

rgb 140, 181, 255
After-system-light.mp4

Before (OS Color Dark Mode)

Before-system-dark.mp4

After (OS Color Dark Mode)

os-color-dark

rgb 203, 226, 248 (Before)

After

rgb 140, 181, 255
After-system-dark.mp4

Motivation and Context

I found a post mentioning that after updating OBS, the control buttons no longer change color. (I’m not sure whether the user was using the System theme.)
I’m not sure how many people are using the system theme, but I’ll fix it (even though I don’t use it myself).

How Has This Been Tested?

Windows 11 25H2
Tested in both Windows light and dark modes.

I changed the System.obt file.
I’m not sure if the code changes are correct.

You can test by changing the Theme in user.ini to Theme=com.obsproject.System.
test_System

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added Bug Fix Non-breaking change which fixes an issue UI/UX Anything to do with changes or additions to UI/UX elements. labels Jul 26, 2025
@WizardCM WizardCM requested a review from Warchamp7 July 26, 2025 23:47
@RytoEX RytoEX added this to the OBS Studio 31.1 milestone Jul 28, 2025
@RytoEX RytoEX self-assigned this Jul 28, 2025
@PatTheMav PatTheMav removed this from the OBS Studio 31.1 milestone Nov 20, 2025
@shiina424 shiina424 force-pushed the Fix-checked-control-button-color-not-changing branch 3 times, most recently from 553c351 to b042509 Compare February 26, 2026 17:30
@shiina424 shiina424 requested a review from Warchamp7 February 26, 2026 17:37
@shiina424 shiina424 force-pushed the Fix-checked-control-button-color-not-changing branch from b042509 to 3358279 Compare March 5, 2026 14:29
@shiina424 shiina424 force-pushed the Fix-checked-control-button-color-not-changing branch from 3358279 to 5b22f19 Compare March 5, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fix Non-breaking change which fixes an issue UI/UX Anything to do with changes or additions to UI/UX elements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants