-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marklet v1.4 #19
Open
shigma
wants to merge
54
commits into
master
Choose a base branch
from
dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Marklet v1.4 #19
+1,292
−1,081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
在 client 中暴露了一个全局变量 marklet,拥有 type, sourceType, config, vm 等属性,会通过 initialize.js 进行初始化
1. core updated to v3.2.4 2. update cli readme file 3. disallow server-client communication when filepath is absent
尝试增加了对层叠式菜单的支持
Focus on impl at present, code style issues (such as oop) shall be postponed.
将 server 和 client 分离……
1. 将一些 API 更换了名称 2. 去除了 inject 的使用 3. 修改了 $menuManager 上 $ref 的实现 4. 解决了多次按 Alt 失效的问题
Menu refactor
...... BUT FAILED
1. 修复了事件接口不统一的 bug 2. 修复了 project 没有初始化的 bug 3. 将 project 模式对应的 sourceType 改为 project,过去的 type 改为 serverType
Project config
1. 修复一处 serverType 写成 type 的问题 2. 修复 test 无法获取深层 data 的问题 3. 修复 dirtree 错误过滤文件夹的问题
jjyyxx
approved these changes
Oct 31, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.4 的大部分任务现已完成,包括下列内容:
下个版本计划的任务:
一些在合并前可以考虑完成的事务:
changed
和origin
属性未实现history.pushState
会有更好的效果注意:合并前请手动发版!