Add contributor endpoint

ocadotechnology · Aug 23, 2024 · ee27954 · ee27954
1 parent 7c30b5b
commit ee27954
Show file tree

Hide file tree

Showing 9 changed files with 19 additions and 35 deletions.
diff --git a/src/api/agreementSignature.ts b/src/api/agreementSignature.ts
diff --git a/src/api/contributor.ts b/src/api/contributor.ts
@@ -16,10 +16,10 @@ export type Contributor = Model<
   {
     email: string
     name: string
-    location: string
+    location?: string
     html_url: string
     avatar_url: string
-    last_login: Date
+    last_login?: Date
   }
 >
 

diff --git a/src/app/schemas.ts b/src/app/schemas.ts
@@ -1,3 +0,0 @@
-import * as yup from "yup"
-
-export const fruitNameSchema = yup.string().max(50)

diff --git a/src/components/FruitNameField.tsx b/src/components/FruitNameField.tsx
diff --git a/src/components/index.tsx b/src/components/index.tsx
@@ -1,2 +0,0 @@
-export { default as FruitNameField } from "./FruitNameField"
-export * from "./FruitNameField"

diff --git a/src/pages/agreementSignatureDetails/AgreementSignatureDetails.tsx b/src/pages/agreementSignatureDetails/AgreementSignatureDetails.tsx
diff --git a/src/pages/agreementSignatureList/AgreementSignatureList.tsx b/src/pages/agreementSignatureList/AgreementSignatureList.tsx
diff --git a/src/pages/contributorDetail/ContributorDetail.tsx b/src/pages/contributorDetail/ContributorDetail.tsx
@@ -1,7 +1,6 @@
-import * as forms from "codeforlife/components/form"
 import * as pages from "codeforlife/components/page"
 import * as yup from "yup"
-import { Typography } from "@mui/material"
+import { Stack, Typography } from "@mui/material"
 // eslint-disable-next-line sort-imports
 import { type FC } from "react"
 import { Link } from "codeforlife/components/router"
@@ -24,11 +23,22 @@ const ContributorDetail: FC<ContributorDetailProps> = () => {
       handleQueryState(retrieveContributorResult, contributor => (
         <pages.Page>
           <pages.Section>
-            <Typography variant="h1">Contributor details</Typography>
-            <forms.Form
-              initialValues={contributor}
-              onSubmit={alert}
-            ></forms.Form>
+            <Typography variant="h1">{contributor.name} details</Typography>
+            <Stack spacing={2}>
+              <Typography variant="h6">Name: {contributor.name}</Typography>
+              <Typography variant="h6">Email: {contributor.email}</Typography>
+              {contributor.location && (
+                <Typography variant="h6">
+                  Location: {contributor.location}
+                </Typography>
+              )}
+              <Typography variant="h6">
+                html_url: {contributor.html_url}
+              </Typography>
+              <Typography variant="h6">
+                avatar_url: {contributor.avatar_url}
+              </Typography>
+            </Stack>
           </pages.Section>
           <pages.Section>
             <Link className="back-to" to={paths.contributors._}>

diff --git a/src/pages/contributorList/ContributorList.tsx b/src/pages/contributorList/ContributorList.tsx
@@ -26,13 +26,11 @@ const ContributorList: FC<ContributorListProps> = () => {
                   {contributor.name} ({contributor.email})
                 </Typography>
 
-                {/* Added an icon to the LinkIconButton for better UX */}
                 <LinkIconButton
                   to={generatePath(paths.contributors.id._, {
                     id: contributor.id,
                   })}
                 >
-                  {/* You can replace 'View' with an icon component like <Icon>eye</Icon> if desired */}
                   <Typography>View</Typography>
                 </LinkIconButton>
               </Stack>
Original file line number	Diff line number	Diff line change
		@@ -1,3 +0,0 @@
		import * as yup from "yup"

		export const fruitNameSchema = yup.string().max(50)
Original file line number	Diff line number	Diff line change
		@@ -1,2 +0,0 @@
		export { default as FruitNameField } from "./FruitNameField"
		export * from "./FruitNameField"