Skip to content

Commit

Permalink
Merge pull request #478 from shym/new-aliases
Browse files Browse the repository at this point in the history
Small cleanups to ease upstreaming
  • Loading branch information
jmid authored Sep 13, 2024
2 parents 5b33b02 + cd5b374 commit 4ad6543
Show file tree
Hide file tree
Showing 18 changed files with 50 additions and 32 deletions.
2 changes: 1 addition & 1 deletion .github/runner.sh
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ case "$1" in
;;
internaltests)
cd "$MULTICORETESTSDIR"
dune runtest -j1 --no-buffer --display=quiet --cache=disabled --error-reporting=twice test/
dune build @internaltests -j1 --no-buffer --display=quiet --cache=disabled --error-reporting=twice
;;
*)
fatal "Unknown command '$1'"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ on:
dune_alias:
description: 'dune alias that should be built in the main step'
type: string
default: 'runtest'
default: 'testsuite'
compiler_repository:
description: 'Repository from which to fetch the compiler'
type: string
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/linux-500-debug.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ jobs:
with:
compiler_ref: refs/tags/5.0.0
dune_profile: 'debug-runtime'
runparam: 's=4096,v=0,V=1'
runparam: 's=4096,V=1'
timeout: 240
2 changes: 1 addition & 1 deletion .github/workflows/linux-51x-debug.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ jobs:
with:
compiler_ref: refs/tags/5.1.1
dune_profile: 'debug-runtime'
runparam: 's=4096,v=0,V=1'
runparam: 's=4096,V=1'
timeout: 240
2 changes: 1 addition & 1 deletion .github/workflows/linux-520-debug.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ jobs:
with:
compiler_ref: refs/tags/5.2.0
dune_profile: 'debug-runtime'
runparam: 's=4096,v=0,V=1'
runparam: 's=4096,V=1'
timeout: 240
2 changes: 1 addition & 1 deletion .github/workflows/linux-530-trunk-debug.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ jobs:
with:
compiler_ref: refs/heads/5.3
dune_profile: 'debug-runtime'
runparam: 's=4096,v=0,V=1'
runparam: 's=4096,V=1'
timeout: 240
2 changes: 1 addition & 1 deletion .github/workflows/linux-540-trunk-debug.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ jobs:
with:
compiler_ref: refs/heads/trunk
dune_profile: 'debug-runtime'
runparam: 's=4096,v=0,V=1'
runparam: 's=4096,V=1'
timeout: 240
18 changes: 15 additions & 3 deletions dune
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,27 @@
(package multicoretests)
(deps (alias src/default)))

; The main test alias
(alias
(name testsuite)
(package multicoretests)
(deps
(alias_rec src/runtest)))

; The internal tests alias
(alias
(name internaltests)
(package multicoretests)
(deps
(alias_rec test/runtest)))

; The aliases to control what is run in CI
; It can either be the full test suite, or focus on a single test
; Aliases ci1 and ci2 are useful to split the test suite into
; subparts, for platforms such as Cygwin which are too slow
(alias
(name ci)
(package multicoretests)
(deps
(alias_rec %{env:DUNE_CI_ALIAS=runtest})))
(alias_rec %{env:DUNE_CI_ALIAS=testsuite})))
; (alias_rec focusedtest)))

; @focusedtest
Expand Down
2 changes: 1 addition & 1 deletion src/array/dune
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
(flags (:standard -w -27))
(libraries qcheck-lin.domain)
; (action (run %{test} --verbose))
(action (echo "Skipping src/array/%{test} from the test suite\n\n"))
(action (progn))
)

(test
Expand Down
2 changes: 1 addition & 1 deletion src/atomic/dune
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
(flags (:standard -w -27))
(libraries qcheck-lin.domain)
; (action (run %{test} --verbose))
(action (echo "Skipping src/atomic/%{test} from the test suite\n\n"))
(action (progn))
)

(test
Expand Down
2 changes: 1 addition & 1 deletion src/domain/dune
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
(package multicoretests)
(libraries qcheck-lin.domain)
; (action (run %{test} --verbose))
(action (echo "Skipping src/domain/%{test} from the test suite\n\n"))
(action (progn))
)

(test
Expand Down
2 changes: 1 addition & 1 deletion src/hashtbl/dune
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
(flags (:standard -w -27))
(libraries qcheck-lin.domain)
; (action (run %{test} --verbose))
(action (echo "Skipping src/hashtbl/%{test} from the test suite\n\n"))
(action (progn))
)

(test
Expand Down
4 changes: 2 additions & 2 deletions src/io/dune
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
;(flags (:standard -w -27))
(libraries qcheck-lin.domain)
; (action (run %{test} --verbose))
(action (echo "Skipping src/io/%{test} from the test suite\n\n"))
(action (progn))
)

(library
Expand All @@ -33,7 +33,7 @@
;(flags (:standard -w -27))
(libraries qcheck-lin.thread lin_tests_spec_io)
; (action (run %{test} --verbose))
(action (echo "Skipping src/io/%{test} from the test suite\n\n"))
(action (progn))
)

(test
Expand Down
4 changes: 2 additions & 2 deletions src/lazy/dune
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
(package multicoretests)
(libraries qcheck-lin.domain)
; (action (run %{test} --verbose))
(action (echo "Skipping src/lazy/%{test} from the test suite\n\n"))
(action (progn))
)

(test
Expand All @@ -23,5 +23,5 @@
(package multicoretests)
(libraries qcheck-lin.domain)
; (action (run %{test} --verbose))
(action (echo "Skipping src/lazy/%{test} from the test suite\n\n"))
(action (progn))
)
6 changes: 3 additions & 3 deletions src/neg_tests/dune
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
(flags (:standard -w -27))
(libraries lin_tests_common qcheck-lin.thread)
; (action (run %{test} --verbose))
(action (echo "Skipping src/neg_tests/%{test} from the test suite\n\n"))
(action (progn))
)

(test
Expand All @@ -106,7 +106,7 @@
(flags (:standard -w -27))
(libraries lin_internal_tests_common qcheck-lin.domain)
; (action (run %{test} --verbose))
(action (echo "Skipping src/neg_tests/%{test} from the test suite\n\n"))
(action (progn))
)

(tests
Expand All @@ -125,5 +125,5 @@
(flags (:standard -w -27))
(libraries lin_internal_tests_common qcheck-lin.effect)
; (action (run ./%{deps} --verbose))
(action (echo "Skipping src/neg_tests/%{test} from the test suite\n\n"))
(action (progn))
)
2 changes: 1 addition & 1 deletion src/queue/dune
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@
(flags (:standard -w -27))
(libraries qcheck-lin.domain qcheck-lin.thread)
;(action (run %{test} --verbose))
(action (echo "Skipping src/queue/%{test} from the test suite\n\n"))
(action (progn))
)
2 changes: 1 addition & 1 deletion src/stack/dune
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
(flags (:standard -w -27))
(libraries qcheck-lin.domain qcheck-lin.thread)
; (action (run %{test} --verbose))
(action (echo "Skipping src/stack/%{test} from the test suite\n\n"))
(action (progn))
)

24 changes: 15 additions & 9 deletions test/dune
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,19 @@
(package qcheck-multicoretests-util)
(libraries qcheck-multicoretests-util)
(action
(setenv MCTUTILS_TRUNCATE ""
(run %{dep:util_pp.exe}))))
(setenv OCAMLRUNPARAM "%{env:OCAMLRUNPARAM=b},v=0"
(setenv MCTUTILS_TRUNCATE ""
(run %{dep:util_pp.exe})))))

(rule
(alias runtest)
(package qcheck-multicoretests-util)
(action
(progn
(with-outputs-to util_pp_trunc150.output
(setenv MCTUTILS_TRUNCATE 150
(run %{dep:util_pp.exe})))
(setenv OCAMLRUNPARAM "%{env:OCAMLRUNPARAM=b},v=0"
(setenv MCTUTILS_TRUNCATE 150
(run %{dep:util_pp.exe}))))
(diff? util_pp_trunc150.expected util_pp_trunc150.output))))

(rule
Expand All @@ -31,8 +33,9 @@
(action
(progn
(with-outputs-to util_pp_trunc79.output
(setenv MCTUTILS_TRUNCATE 79
(run %{dep:util_pp.exe})))
(setenv OCAMLRUNPARAM "%{env:OCAMLRUNPARAM=b},v=0"
(setenv MCTUTILS_TRUNCATE 79
(run %{dep:util_pp.exe}))))
(diff? util_pp_trunc79.expected util_pp_trunc79.output))))

(rule
Expand All @@ -41,8 +44,9 @@
(action
(progn
(with-outputs-to util_pp_trunc5.output
(setenv MCTUTILS_TRUNCATE 5
(run %{dep:util_pp.exe})))
(setenv OCAMLRUNPARAM "%{env:OCAMLRUNPARAM=b},v=0"
(setenv MCTUTILS_TRUNCATE 5
(run %{dep:util_pp.exe}))))
(diff? util_pp_trunc5.expected util_pp_trunc5.output))))

(executable
Expand Down Expand Up @@ -91,7 +95,9 @@
(package qcheck-stm)
(libraries qcheck-stm.sequential threads.posix)
(action
(with-accepted-exit-codes 1 (run ./%{test} --seed 229109553))))
(with-accepted-exit-codes 1
(setenv OCAMLRUNPARAM "%{env:OCAMLRUNPARAM=b},v=0"
(run ./%{test} --seed 229109553)))))

(test
(name stm_next_state_exc)
Expand Down

0 comments on commit 4ad6543

Please sign in to comment.