You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This adds three negative tests for references, mutable record fields and arrays, that tends to trigger memory data-races (the tests are very similar, I'll let you choose which ones to keep!) It takes a lot of trials, about 50k on my computer on a good day, so perhaps the count = 100_000 is too low... and it's very hard for the shrinker to reproduce the observed data-race.
Many thanks to @OlivierNicole for recommending qcheck-lin as a way to confirm that my hardware is doing read/write reordering optimizations :)
Note: We already have Array tests in https://github.com/jmid/multicoretests/blob/main/src/array/lin_tests_dsl.ml
Because they test more Array functions they tend to find and report observed "sequential inconsistency" of these, rather than performing a focused data-race drilling of get and set. As such, there may be a good reason to run both though... 🤔
For all three, I'm also wondering if playing with rep_count (how many times each instance is repeated) could help reduce the outer iteration count - and hence overall testing time 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds three negative tests for references, mutable record fields and arrays, that tends to trigger memory data-races (the tests are very similar, I'll let you choose which ones to keep!) It takes a lot of trials, about 50k on my computer on a good day, so perhaps the
count = 100_000is too low... and it's very hard for the shrinker to reproduce the observed data-race.Many thanks to @OlivierNicole for recommending
qcheck-linas a way to confirm that my hardware is doing read/write reordering optimizations :)