fix: handle case where doc does not lex as ocaml #2684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ocaml-ppx#2679 Formatting `mld` files can crash when the input file cannot be lexed as ocaml. This can happen with LaTeX is found in `{m ...}` or C code in `{@c[ ... ]}`, for example. In that case we would crash when building the list of tokens in the file; however it's not used in the `mld` case.
emillon
force-pushed
the
mld-lexing-errors
branch
from
794e1c4 to
b401c6e
Compare
There was a problem hiding this comment.
Copilot reviewed 1 out of 6 changed files in this pull request and generated 1 comment.
Files not reviewed (5)
- lib/Parse_with_comments.ml: Language not supported
- test/passing/refs.default/doc.mld.ref: Language not supported
- test/passing/refs.janestreet/doc.mld.ref: Language not supported
- test/passing/refs.ocamlformat/doc.mld.ref: Language not supported
- test/passing/tests/doc.mld: Language not supported
Co-authored-by: Copilot <[email protected]>
|
I don't really like that we catch the exception even when we are not parsing documentation, but I checked and we cannot match on fragment at this stage. Maybe an Still I think its okay to merge as-is, the exception will be raised elsewhere when truly parsing an ocaml file. |
|
yeah I agree it's not ideal. we can't really make the |
EmileTrotignon
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2679
Formatting
mldfiles can crash when the input file cannot be lexed as ocaml. This can happen with LaTeX is found in{m ...}or C code in{@c[ ... ]}, for example.In that case we would crash when building the list of tokens in the file; however it's not used in the
mldcase.