Simplify fmt_function #2690
Merged
Simplify fmt_function #2690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmileTrotignon
added
the
no changelog
EmileTrotignon
added a commit
to EmileTrotignon/ocamlformat
that referenced
this pull request
Apr 16, 2025
* main: fix doc comment interaction with ;; (ocaml-ppx#2691) use ubuntu latest for ci (ocaml-ppx#2692) Simplify fmt_function (ocaml-ppx#2690)
davesnx
pushed a commit
to ocaml-mlx/ocamlformat-mlx
that referenced
this pull request
May 6, 2025
* `last_arg` and `has_label` is computed from context, `label` is given in `pro`.
davesnx
pushed a commit
to ocaml-mlx/ocamlformat-mlx
that referenced
this pull request
May 6, 2025
* `last_arg` and `has_label` is computed from context, `label` is given in `pro`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
last_arg and has_label is computed from context, label is given in
pro.This has no diff, and just make
fmt_functiona little more generic.I want to confirm that there are no diffs on test-branch, and then merge.