Open
Conversation
An minimal unsafe version of Domain.DLS is used to implement Format_. This shim module just needs to be removed if OCamlformat ever use parallelism.
This bug fix breaks OCamlformat and will be fixed in a separate PR.
Add commented-out code in order to reduce the textual diff with upstream code.
The formatting of this option depended heavily on the Format bug.
Ensure that comments in chains of operators either fit on a single line
or break the line after each comments. For example:
foo (* 1 *) ^ bar (* 2 *) ^ baz (* 3 *)
or if too long to fit a single line:
foo (* 1 *)
^ bar (* 2 *)
^ baz (* 3 *)
But never:
foo (* 1 *) ^ bar (* 2 *)
^ baz (* 3 *)
This restore the previous behavior.
Collaborator
Author
|
This change reflow a lot of comments and string literals, which might impact a lot of code. However, many changes are less impacting or result in nicer code. For example, comments just after a Some or-patterns are also reflow: What are your opinion ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #2777
This backports ocaml/ocaml#13853 and fix the worst formatting changes.
This changes the formatting in many cases but a lot of the changes are improvements.