Expose bare minimum to manually order transformations#630
Draft
NathanReb wants to merge 1 commit intoocaml-ppx:mainfrom
Draft
Expose bare minimum to manually order transformations#630NathanReb wants to merge 1 commit intoocaml-ppx:mainfrom
NathanReb wants to merge 1 commit intoocaml-ppx:mainfrom
Conversation
Collaborator
Author
|
This is a first draft to attempt a fix for #628. I mostly aimed at ensuring that would work but the current version might be a bit permissive, we might end up exposing something like val reorder_transformations : cmp: (string -> string -> int) -> unit |
This should allow users or dune itself to set the order of transformations. It will only impact transformations that define global rewritings, context free rules or other special rewritings won't be impacted by this. Signed-off-by: Nathan Rebours <[email protected]>
NathanReb
force-pushed
the
expose-transformations
branch
from
2432902 to
72d000b
Compare
Collaborator
Author
|
CC @davesnx if you want to give this a try and confirm it can be used to fix the issues you had. We can then discuss what the best API for this is and how it can eventually be used by dune. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow users or dune itself to set the order of transformations.
It will only impact transformations that define global rewritings, context free rules or other special rewritings won't be impacted by this.
It's important to note that nothing actually ties the ppx's library name to the transformation name and that a single ppx may define multiple transformations so it might be hard for either dune or even ppxlib to actually order things per-ppx.