Add support for DUNE_VCS_{DESCRIBE,COMMIT_ID,FILES} #11485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the possibility to customize `dune subst` behaviour with environment variables, instead of querying the VCS. The need arose in Debian, where unsubstituted sources are preferred as basis for packaging but break substitution when those sources are not used from upstream VCS. For more background, see the discussion starting at [1]. [1] https://lists.debian.org/debian-ocaml-maint/2025/02/msg00106.html Signed-off-by: Stephane Glondu <[email protected]>
glondu
force-pushed
the
dune-vcs-override
branch
from
68d1574 to
9fd40dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the possibility to customize
dune substbehaviour with environment variables, instead of querying the VCS.The need arose in Debian, where unsubstituted sources are preferred as basis for packaging but break substitution when those sources are not used from upstream VCS. For more background, see the discussion starting at [1].
[1] https://lists.debian.org/debian-ocaml-maint/2025/02/msg00106.html
This is work in progress that I started a few hours before @SnarkBoojum opened #11484, but it is a solution to the problem exposed there.