Require js_of_ocaml >= 6 #11487
Merged
Require js_of_ocaml >= 6 #11487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It works with older versions but the error message changed in version 6, so the test fail due to the wording of the error. This makes sure that people updating their system using `make dev-switch` will get their possibly existing installation updated. Signed-off-by: Marek Kubica <[email protected]>
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/dune
that referenced
this pull request
Feb 18, 2025
Otherwise the describe test is failing because the description does not match. Similar reasoning as ocaml#11487. Signed-off-by: Marek Kubica <[email protected]>
nojb
added a commit
that referenced
this pull request
Feb 18, 2025
Otherwise the describe test is failing because the description does not match. Similar reasoning as #11487. Signed-off-by: Marek Kubica <[email protected]> Co-authored-by: Nicolás Ojeda Bär <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works with older versions but the error message changed in version 6, so the test fail due to the wording of the error if the person uses
jsoo.5.9.1.This makes sure that people updating their system using
make dev-switchwill get their possibly existing installation updated.